Merged
Conversation
cjumel
approved these changes
Feb 12, 2026
Contributor
cjumel
left a comment
cjumel
left a comment
There was a problem hiding this comment.
Thanks for the PR!
There's just one point to address, otherwise it looks good 🙂
Contributor
Author
|
removed the timeouts from the readme @cjumel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
timeoutparameter (in seconds) tosearch,async_search,fetch, andasync_fetchmethods. When the HTTP request exceeds the given duration, a newLinkupTimeoutErroris raised. Defaults toNone(no timeout), preserving backward compatibility.Checklist
make install-devcommand)before creating any commit, or I have run successfully the
make format-lintcommand on mychanges.
make testcommand on my changes.README.mdif my changes affected it.