Fix overwriting ssh config bug#17
Open
EasonLiao wants to merge 4 commits intoLinkedInAttic:masterfrom
Open
Conversation
Contributor
|
One comment would be to add initialization for all the config variables before reading the config as it is recommended by pep8. Also can you include the unittest results for the changes |
Author
|
Sorry for the delay! I had problems running the unit tests and I'll start looking into it again soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix to #16 (default parameters in the constructor of
ShellScriptHandleroverwrote the configs that users specified in the config file)The parameters of ShellScriptHandler are never passed to the constructor of it, so I fixed it by getting rid of these parameters and get everything from config file. This implies we need to set every config parameter in config file, which seems fine to me.