Make terminal_actions int #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wuodan
force-pushed
the
upstream/issue/83_terminal_actions_float_not_int
branch
from
58883c8 to
53c4d2f
Compare
Member
|
Wouldn't it make more sense to replace your hardcoded 2**31-1 by sys.maxsize? |
Contributor
Author
I tried as described in #83. sys.maxsize leads to
|
Warning was: Expected type 'int', got 'float' instead Fixes Linesight-RL#83
Wuodan
force-pushed
the
upstream/issue/83_terminal_actions_float_not_int
branch
from
53c4d2f to
c0f690f
Compare
Member
|
This error is very confusing...maybe np.iinfo(np.int32).max then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning was:
Expected type 'int', got 'float' instead
Fixes #83