fix: nightly release signature validation#6726
Merged
vitormattos merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
The occ integrity:sign-app command needs write access to the appinfo directory to create signature.json. This adds chmod -R a+w after copying appinfo to ensure the directory is writable regardless of file ownership. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The 'Sign app' step was re-signing an already signed tarball created by the Makefile. This caused signature validation failures on the Nextcloud Appstore API because: 1. Makefile correctly signs at build/artifacts/sign/libresign 2. Duplicate step extracted, re-signed at wrong path, and recreated tarball 3. This corrupted the original valid signature 4. API rejected with 'invalid padding' or 'bad signature' errors The Makefile already handles all signing correctly: - Downloads certificate from GitHub - Signs setup files with libresign:developer:sign-setup - Signs app files with occ integrity:sign-app - Creates properly signed tarball Removing this redundant step fixes nightly releases not appearing on apps.nextcloud.com. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/6726/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2aec68be dfcabe12
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6726/stable33Error: Failed to push branch backport/6726/stable33: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.