Skip to content

Adds retry when failing to rename tmp folder to data #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdha merged 1 commit into from
Aug 14, 2025
Merged

Adds retry when failing to rename tmp folder to data #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion bagit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import signal
import sys
import tempfile
import time
import unicodedata
import warnings
from collections import defaultdict
Expand Down Expand Up @@ -229,7 +230,16 @@ def make_bag(
_("Moving %(source)s to %(destination)s"),
{"source": temp_data, "destination": "data"},
)
os.rename(temp_data, "data")
while True:
try:
os.rename(temp_data, "data")
break
except PermissionError as e:
if hasattr(e, "winerror") and e.winerror == 5:
LOGGER.warning(_("PermissionError [WinError 5] when renaming temp folder. Retrying in 10 seconds..."))
time.sleep(10)
else:
raise

# permissions for the payload directory should match those of the
# original directory
Expand Down