Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 29 additions & 12 deletions check/classic/classic.exp
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
=========================
./examples/using_dune/preprocessed_lib/preprocessed.mli:1: unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:3: internally_used
./examples/using_dune/preprocessed_lib/preprocessed.mli:38: internally_used_f
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:2: unused

./examples/using_dune/unwrapped_lib/opt_args/opt_args.mli:1: unused_fun_with_single_never_used_opt_arg
Expand Down Expand Up @@ -242,7 +243,15 @@ Nothing else to report in this section
.> OPTIONAL ARGUMENTS: ALWAYS:
=============================
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?always
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?internally
./examples/using_dune/preprocessed_lib/preprocessed.ml:59: ?always
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: ?always
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?always
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?externally
./examples/using_dune/preprocessed_lib/preprocessed.mli:44: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:53: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:59: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: ?always

./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:1: ?always
./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:8: ?always
Expand Down Expand Up @@ -378,10 +387,18 @@ Nothing else to report in this section

.> OPTIONAL ARGUMENTS: NEVER:
============================
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?externally
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:65: ?opt
./examples/using_dune/preprocessed_lib/preprocessed.ml:59: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:84: ?opt
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?internally
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?never
./examples/using_dune/preprocessed_lib/preprocessed.mli:44: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:53: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:65: ?opt
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:59: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:77: ?opt

./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:1: ?never
./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:8: ?never
Expand Down Expand Up @@ -486,16 +503,16 @@ Nothing else to report in this section

.> CODING STYLE:
===============
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed.ml:65: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed.ml:66: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:67: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:65: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:66: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:67: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed.ml:83: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:83: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed.ml:84: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed.ml:85: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:86: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:76: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:76: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:77: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:78: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:79: let x = ... in x (=> useless binding)

./examples/using_dune/unwrapped_lib/opt_args/opt_args_in_higher_order_fun.ml:20: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/unwrapped_lib/opt_args/opt_args_in_higher_order_fun.ml:22: val f: ... -> (... -> ?_:_ -> ...) -> ...
Expand Down
45 changes: 31 additions & 14 deletions check/classic/classic.ref
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
=========================
./examples/using_dune/preprocessed_lib/preprocessed.mli:1: unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:3: internally_used
./examples/using_dune/preprocessed_lib/preprocessed.mli:38: internally_used_f
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:2: unused

./examples/using_dune/unwrapped_lib/opt_args/opt_args.mli:1: unused_fun_with_single_never_used_opt_arg
Expand Down Expand Up @@ -242,7 +243,15 @@ Nothing else to report in this section
.> OPTIONAL ARGUMENTS: ALWAYS:
=============================
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?always
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?internally
./examples/using_dune/preprocessed_lib/preprocessed.ml:59: ?always
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: ?always
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?always
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?externally
./examples/using_dune/preprocessed_lib/preprocessed.mli:44: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:53: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:59: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: ?always

./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:1: ?always
./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:8: ?always
Expand Down Expand Up @@ -378,10 +387,18 @@ Nothing else to report in this section

.> OPTIONAL ARGUMENTS: NEVER:
============================
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?externally
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:65: ?opt
./examples/using_dune/preprocessed_lib/preprocessed.ml:59: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:84: ?opt
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?internally
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?never
./examples/using_dune/preprocessed_lib/preprocessed.mli:44: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:53: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:65: ?opt
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:59: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:77: ?opt

./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:1: ?never
./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:8: ?never
Expand Down Expand Up @@ -486,16 +503,16 @@ Nothing else to report in this section

.> CODING STYLE:
===============
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed.ml:65: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed.ml:66: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:67: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:65: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:66: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:67: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed.ml:83: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:83: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed.ml:84: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed.ml:85: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:86: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:76: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:76: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:77: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:78: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:79: let x = ... in x (=> useless binding)

./examples/using_dune/unwrapped_lib/opt_args/opt_args_in_higher_order_fun.ml:20: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/unwrapped_lib/opt_args/opt_args_in_higher_order_fun.ml:22: val f: ... -> (... -> ?_:_ -> ...) -> ...
Expand Down Expand Up @@ -533,7 +550,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 460
Success: 460
Total: 477
Success: 477
Failed: 0
Ratio: 100.%
40 changes: 28 additions & 12 deletions check/internal/internal.exp
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,15 @@ Nothing else to report in this section
.> OPTIONAL ARGUMENTS: ALWAYS:
=============================
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?always
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?internally
./examples/using_dune/preprocessed_lib/preprocessed.ml:59: ?always
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: ?always
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?always
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?externally
./examples/using_dune/preprocessed_lib/preprocessed.mli:44: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:53: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:59: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: ?always

./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:1: ?always
./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:8: ?always
Expand Down Expand Up @@ -346,10 +354,18 @@ Nothing else to report in this section

.> OPTIONAL ARGUMENTS: NEVER:
============================
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?externally
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:65: ?opt
./examples/using_dune/preprocessed_lib/preprocessed.ml:59: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:84: ?opt
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?internally
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?never
./examples/using_dune/preprocessed_lib/preprocessed.mli:44: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:53: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:65: ?opt
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:59: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:77: ?opt

./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:1: ?never
./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:8: ?never
Expand Down Expand Up @@ -454,16 +470,16 @@ Nothing else to report in this section

.> CODING STYLE:
===============
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed.ml:65: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed.ml:66: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:67: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:65: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:66: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:67: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed.ml:83: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:83: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed.ml:84: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed.ml:85: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:86: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:76: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:76: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:77: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:78: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:79: let x = ... in x (=> useless binding)

./examples/using_dune/unwrapped_lib/opt_args/opt_args_in_higher_order_fun.ml:20: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/unwrapped_lib/opt_args/opt_args_in_higher_order_fun.ml:22: val f: ... -> (... -> ?_:_ -> ...) -> ...
Expand Down
44 changes: 30 additions & 14 deletions check/internal/internal.ref
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,15 @@ Nothing else to report in this section
.> OPTIONAL ARGUMENTS: ALWAYS:
=============================
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?always
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?internally
./examples/using_dune/preprocessed_lib/preprocessed.ml:59: ?always
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: ?always
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?always
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?externally
./examples/using_dune/preprocessed_lib/preprocessed.mli:44: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:53: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:59: ?always
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: ?always

./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:1: ?always
./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:8: ?always
Expand Down Expand Up @@ -346,10 +354,18 @@ Nothing else to report in this section

.> OPTIONAL ARGUMENTS: NEVER:
============================
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?externally
./examples/using_dune/preprocessed_lib/preprocessed.ml:53: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:65: ?opt
./examples/using_dune/preprocessed_lib/preprocessed.ml:59: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: ?never
./examples/using_dune/preprocessed_lib/preprocessed.ml:84: ?opt
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?internally
./examples/using_dune/preprocessed_lib/preprocessed.mli:31: ?never
./examples/using_dune/preprocessed_lib/preprocessed.mli:44: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:53: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:65: ?opt
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:59: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: ?never
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:77: ?opt

./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:1: ?never
./examples/using_dune/unwrapped_lib/opt_args/mixed_args.ml:8: ?never
Expand Down Expand Up @@ -454,16 +470,16 @@ Nothing else to report in this section

.> CODING STYLE:
===============
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:64: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed.ml:65: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed.ml:66: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:67: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:64: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:65: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:66: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:67: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed.ml:83: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:83: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed.ml:84: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed.ml:85: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed.ml:86: let x = ... in x (=> useless binding)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:76: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:76: unit pattern unit_binding
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:77: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:78: let () = ... in ... (=> use sequence)
./examples/using_dune/preprocessed_lib/preprocessed_no_intf.ml:79: let x = ... in x (=> useless binding)

./examples/using_dune/unwrapped_lib/opt_args/opt_args_in_higher_order_fun.ml:20: val f: ... -> (... -> ?_:_ -> ...) -> ...
./examples/using_dune/unwrapped_lib/opt_args/opt_args_in_higher_order_fun.ml:22: val f: ... -> (... -> ?_:_ -> ...) -> ...
Expand Down Expand Up @@ -501,7 +517,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 430
Success: 430
Total: 446
Success: 446
Failed: 0
Ratio: 100.%
Loading