Add unit tests and enable comprehensive coverage#212
Open
Conversation
- Update .nycrc.json with all: true for comprehensive coverage - Add lib.aws-util.utest.ts (20 tests) - Add lib.DynamodbFetcher.utest.ts (DynamoDB fetcher tests) - Add lib.parser-util.utest.ts (parser utility tests) Coverage: 23.16% -> 25.75% (310 tests)
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| "lib/**/*.js", | ||
| "wrappers/**/*.js", | ||
| "index.js" | ||
| ], |
There was a problem hiding this comment.
Missing TypeScript test file exclusion pattern
Low Severity
The exclude pattern only includes **/*.utest.js but not **/*.utest.ts. With all: true enabled and TypeScript extensions configured, nyc now processes .ts source files directly. If a .utest.ts file were created in the lib/ directory (matching the include pattern lib/**/*.ts), it wouldn't be excluded since **/*.utest.js only matches JavaScript test files. This could incorrectly inflate coverage metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allflag for nyc coverage to include all source filesChanges
.nycrc.jsonwithall: trueand proper include patternslib.aws-util.utest.ts- tests for aws-util module (20 tests)lib.DynamodbFetcher.utest.ts- tests for DynamoDB fetcherlib.parser-util.utest.ts- tests for parser utilitiesTest plan
Note
Improves coverage and validation of core utilities without changing runtime code.
.nycrc.jsonto includelib/**/*,wrappers/**/*.js,index.jsand setsall: truefor comprehensive coveragetest/lib.aws-util.utest.tscoveringcopy,error, anddate.getDatetest/lib.DynamodbFetcher.utest.tscovering constructor behavior,keyToString, andjoinbatching/deduplication pathstest/lib.parser-util.utest.tscovering enums,fieldParsers,parsers,createParser, andFastJsonPlusWritten by Cursor Bugbot for commit 10f3094. This will update automatically on new commits. Configure here.