Skip to content

Conversation

@LeiQL
Copy link
Owner

@LeiQL LeiQL commented May 22, 2024

  • Controller: add upsert and delete calls in Reconcile to add required labels for reference maintainance. Not adding labels in webhook as the tags can be a identifier to check whether the labels (rootResource, version and latest tag) are added or not.

  • Vendor: change vendor route and add list as default route needs "objectname/version".

  • Manager: maintain labels in manager. Add rootResource and version in state and refreshLabels to indicate whether latest label needs to be added or removed. DeleteState accepts ":" object to identify rootResource for latest removal and adding for other objects. Support GetLatestState to fetch latest object

  • Provider: k8s state providers handles the calls from manager. Based on refreshLabels bool, maintain tag=latest label.
    - Create new: remove current latest label in the same group (the same rootResource) and add latest label for the new item.
    - Update: check if the current item is the last created. If yes, add latest label.
    - Delete: if current item has latest label, find the last created in the same group and assign latest label.

  • API client: accepts /objects/version route in creation and deletion for versioned objects

  • Test: fix object reference using new : type

  • Temporarily disable instance and target controller unit test. Will fix in other PRs.

  • Materialize: require objectState.ObjectMeta.Name as "object:version" to maintain the same naming convension and labels (for example, scenario 04)

LeiQL added 7 commits May 20, 2024 11:17
idempotent

reconcile idempotent

remove

fix target fetch

condition check

fix after rebase

inactive reconcile
fix

fix

fix scenario

fix rebase
@LeiQL LeiQL requested a review from coderdjw as a code owner May 22, 2024 11:17
@LeiQL LeiQL force-pushed the users/leqia/versioningsupport2 branch from dce4504 to afeb68b Compare May 22, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants