Open
Conversation
Uffizzi Preview Environment☁️ https://app.uffizzi.com//github.com/Leenday/task_manager/pull/29 ⚙️ Updating now by workflow run 3852834403. What is Uffizzi? Learn more |
YJorge
reviewed
Feb 16, 2023
| def new; end | ||
|
|
||
| def create | ||
| @user = User.find_by(email: params.dig('user', 'email')) |
YJorge
reviewed
Feb 16, 2023
| @user = GlobalID::Locator.locate_signed(params[:token], for: 'password_reset') | ||
| if @user.nil? | ||
| redirect_to new_session_path | ||
| elsif @user.reset_password_token_digest != params[:token] |
There was a problem hiding this comment.
Для валидации данных, поступающих в контроллер, используют формы
There was a problem hiding this comment.
- пользователю необходимо сообщить что у него не так
YJorge
reviewed
Feb 16, 2023
| validates :last_name, presence: true, length: { minimum: 2 } | ||
| validates :email, presence: true, uniqueness: true, format: { with: /\w*@{1}\w*/ } | ||
|
|
||
| def generate_token |
There was a problem hiding this comment.
метод не относится к модели. Нужно вынести в отдельный сервис
YJorge
reviewed
Feb 16, 2023
| html lang="en" | ||
| head | ||
| meta http-equiv="Content-Type" content="text/html; charset=utf-8" | ||
| title="Email template" |
YJorge
reviewed
Feb 16, 2023
| DATABASE_USERNAME: postgres | ||
| DATABASE_PASSWORD: postgres | ||
|
|
||
| MAILER_USERNAME: fake |
There was a problem hiding this comment.
не очень решение. Пересобирать контейнер при добавлении/удалении переменных не очень хочется
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.