Skip to content

add CHANGELOG#49

Merged
leifdenby merged 1 commit intoLeeds-MONC:masterfrom
leifdenby:add-changelog
May 20, 2021
Merged

add CHANGELOG#49
leifdenby merged 1 commit intoLeeds-MONC:masterfrom
leifdenby:add-changelog

Conversation

@leifdenby
Copy link
Collaborator

@leifdenby leifdenby commented May 4, 2021

I've been thinking about how we can keep an up-to-date changelog for MONC, and here's my suggestion (modelling this on xarray's "whats-new.rst" file):

Once a pull-request has reached the final stages where we're happy for it to be merged the author of the pull-request should add a line to CHANGELOG.md in the "unreleased" section with one sentence summarising the change. This section will be split into at least "new features" and "bug fixes" subsections, and if the pull-request introduces a breaking change into should be a separate "breaking changes" subsection.

Sound ok @sjboeing, @cemac-ccs, @MarkUoLeeds, @ralphburton, @eers1?

We've already got a few changes since v0.9.0 (where we forked from MOSRS) so I think we should get this CHANGELOG added before we make any more additions/changes (e.g. #48, #47, #46)

Please check if you're happy with the format and what I've pull in the CHANGELOG so far: https://github.com/leifdenby/monc/blob/add-changelog/CHANGELOG.md (@sjboeing and @cemac-ccs in particular)

@cemac-ccs
Copy link
Collaborator

This looks good to me. To be more informative it might be a good idea to explain areas that may affect running code, such as the changes made for arc compatibility which are designed to allow gnu >=7 compatibility (but are unfortunately incomplete).
Do you want me to add this changelog in my PR, or wait for it to be pulled in to the trunk?

@ralphburton
Copy link
Collaborator

ralphburton commented May 6, 2021 via email

@leifdenby
Copy link
Collaborator Author

just spoke to @sjboeing and he's happy with this too, so I'm going to merge. Hurray for having a changelog from now on!

@leifdenby leifdenby merged commit 544d286 into Leeds-MONC:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments