-
Notifications
You must be signed in to change notification settings - Fork 260
DEVREL-1240 QoL batch 2 #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DEVREL-1240 QoL batch 2 #1902
Conversation
🧪 E2E Test StatusE2E tests are non-blocking and validate real blockchain interactions. Failures may occur due to network issues, RPC rate limits, or external service downtime. Test Runs (Newest First): |
|
will collapse this into another PR |
PR SummaryLow Risk Overview CI/non-interactive flows are fixed by gating confirmation prompts behind Written by Cursor Bugbot for commit 7ac1ffd. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
|
|
||
| if (onlyOftStore && !ci) { | ||
| const continueWithOnlyOftStore = await promptToContinue( | ||
| `You have chosen \`--only-oft-store true\`. This means that only the OFT Store will be able to mint new tokens${freezeAuthorityStr ? '' : ' and that the Freeze Authority will be immediately renounced'}. Continue?` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI flag not respected for prompts in lzapp-migration
Medium Severity
The --ci flag is defined in examples/lzapp-migration/tasks/solana/createOFT.ts but the confirmMaxSupply and continueFreezeAuthority prompts do not check it. These prompts will block execution even when --ci is passed, preventing automated CI workflows. The equivalent file in examples/oft-solana/tasks/solana/createOFT.ts correctly wraps these prompts with if (!ci) checks.
There should be a helper to go from endpoint id to network name
Problem
Changes
Notes
verify-contractpackagelz-definitionsbut that package is in monorepo, not in devtools. Easier to make the change here. Also, lz-definitions does not currently have chainkey<>chainId mappingHow to use
--only-oft-store should be a flag, not param
Problem
Changes
across oft-solana and lzapp-migration examples.
Solana OFT: Prompts should respect --ci flag
Problem
Changes