Skip to content

Conversation

@nicoledow
Copy link
Contributor

@nicoledow nicoledow commented Dec 19, 2025

Items Addressed

These updates should address all "critical" and "high" severity dependabot alerts.

Author Checklist

  • Add unit test(s)
  • Update documentation (if necessary)
  • Update version in version.rb following versioning guidelines

nio4r (2.7.4)
nokogiri (1.16.4-arm64-darwin)
nio4r (2.7.5)
nokogiri (1.18.10-arm64-darwin)
Copy link
Contributor Author

@nicoledow nicoledow Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nokogiri needed to be upgraded to 1.18.4+ to resolve a couple of critical dependabot security warnings (listed below). Since nokogiri is not a direct dependency of decanter but a sub-dependency, I had to update a few other gems:

  1. Warning 1
  2. Warning 2

Changes made:

  • Updated rails-html-sanitizer from >= 1.0.4 to >= 1.6.2
    • rails-html-sanitizer 1.6.0 (bundled with Rails 7.1.3.2) constrains nokogiri to ~> 1.14, which blocks upgrading to 1.18.4+
    • Version 1.6.2+ allows nokogiri >= 1.18.4
  • Constrained Rails to ~> 7.1.3 (allows 7.1.6, latest 7.1.x)
    • Keeps Rails 7.1.x compatibility while enabling nokogiri upgrade

Copy link
Contributor Author

@nicoledow nicoledow Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the process, activestorage was upgraded to 7.1.6, which will resolve the active storage critical security alert which recommends upgrading to 7.1.5.2+.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

activesupport
rails (>= 7.1.3.2)
rails-html-sanitizer (>= 1.0.4)
rack (>= 3.1.18)
Copy link
Contributor Author

@nicoledow nicoledow Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoledow nicoledow changed the title Critical dependabot-recommended updates (December 2025) Critical and high-level dependabot-recommended security updates (December 2025) Dec 19, 2025
@nicoledow nicoledow marked this pull request as ready for review December 19, 2025 17:37
Copy link

@kweingart08 kweingart08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from a dependency standpoint — thanks for the thorough notes.
Just to sanity check: were you able to bundle + boot this version locally with the updated Rails/Rack/Nokogiri combo?

nio4r (2.7.4)
nokogiri (1.16.4-arm64-darwin)
nio4r (2.7.5)
nokogiri (1.18.10-arm64-darwin)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nicoledow
Copy link
Contributor Author

@kweingart08 Thanks! Yes, I tested bundling on a Rails 7 and a Rails 8 project.

@nicoledow nicoledow merged commit ca868f0 into main Dec 23, 2025
6 checks passed
@nicoledow nicoledow deleted the dec-critical-dependabot branch December 23, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ActiveStorage critical dependabot security warning Nokogiri critical security dependabot warning

3 participants