Just testing PR flow. #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castavridis
commented
Mar 13, 2018
Author
castavridis
left a comment
castavridis
left a comment
There was a problem hiding this comment.
Walking through reviewing code.
| @@ -1,3 +1,4 @@ | |||
| <!-- NOTE: Testing code review flow.--> | |||
Author
There was a problem hiding this comment.
Reasoning for change could go here?
| <!-- NOTE: Testing code review flow.--> | ||
| <html> | ||
| <head> | ||
| <title>Git Cheat Sheet</title> |
Author
There was a problem hiding this comment.
Can comment on lines of code outside of the commit?
Author
There was a problem hiding this comment.
But doesn't work on lines below the code fold. Only lines close to the change.
Author
|
Proposed PR flow for code review:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.