Skip to content

Conversation

@mrossi113
Copy link
Contributor

No description provided.

@csj1012 csj1012 added CI Drupal 9 Roadmap temporary label for items added to roadmap; LCM plans to spend time on these. labels Nov 11, 2020
@mrossi113
Copy link
Contributor Author

Looking into how to make Mannequin compatible with Drupal 9 and backward compatible with Drupal 8 versions. So are we are seeing some problems with adding Drupal 9.

Here are the issues so far:

  • We need to add Symfony ^4.0 and Twig ^2.12.0
  • We currently use silex/silex as a web framework in Mannequin.php which is at end of life and does not support Symfony 4.0
  • Some work still needs to be done to see what can be used instead of silex/silex for Mannequin and work with multiple different versions of Symfony.

@mrossi113
Copy link
Contributor Author

We are moving the silex/silex to symfony/flex within the Mannequin project for Drupal 9 update. This way we can keep it within Symfony eco-system.

@csj1012 csj1012 linked an issue Feb 3, 2021 that may be closed by this pull request
@pjoulot
Copy link
Contributor

pjoulot commented Apr 20, 2021

Hi, I just tried to use your D9 branch.
I cannot use it on D9 because of this dependency:
"symfony/finder": "^2.7 ||^3.0"

I have a conflict:
conflicts with symfony/dependency-injection[v4.4.20]

Changin to "symfony/finder": "^2.7 ||^3.0 || ^4.0 || ^5.0" fix the dependency issue. But how do you compile exactly? The mannequin executable is missing from bin. I've read the contributing file but I didn't get what is the procedure to package.

I found out that the package command is probably something like this:
node scripts/release.js 2.0.0 --no-commit

Which is crashing for me because it is using "git st" which is not a native git command. It would be great to replace by "git status".

And then after creating my git alias, it is still crashing for me:
`fs.js:160
throw new ERR_INVALID_CALLBACK(cb);
^

TypeError [ERR_INVALID_CALLBACK]: Callback must be a function. Received undefined`

Maybe I burned some steps but it is hard to figure things out by exploring the repo. I am using Node v14.15.5, what version is actually supported because it says above v6.

EDIT: Using v8.17.0 seems to pass but still no executable bin/mannequin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Drupal 9 Roadmap temporary label for items added to roadmap; LCM plans to spend time on these.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mannequin not compatible with Drupal 9

4 participants