Conversation
I noticed that the file wasn't completed when compared to the other json files.
Pyrofab
approved these changes
Jul 25, 2025
Member
Pyrofab
left a comment
Pyrofab
left a comment
There was a problem hiding this comment.
Nice work, the previous translation was indeed quite dated. Left a couple stylistic comments, but could be merged as is.
| "death.attack.amethyst_shard": "%1$s a été poignardé par un éclat d’améthyste provenant de la bombe en améthyste de %2$s", | ||
| "death.attack.icicle": "%1$s a été glacé par %2$s", | ||
| "subtitles.blast.entity.pipe_bomb.tick": "La bombe artisanale fait tic-tac", | ||
| "subtitles.blast.entity.pipe_bomb.explode": "La bombe artisanale explose" |
Member
There was a problem hiding this comment.
How does it work for other explosion subtitles ? Is it "La bombe" or "Une bombe" ?
Contributor
Author
There was a problem hiding this comment.
I mean even though it directly translates to "a pipe bomb explodes" I still think I should choose la instead because I kind of wanted it to refer to that specific bomb in the moment. Completely your decision btw I can change it
| "item.blast.confetti_trigger_bomb": "Bombe à confettis à détente", | ||
| "item.blast.dirt_bomb": "Bombe de terre", | ||
| "item.blast.dirt_trigger_bomb": "Bombe de terre à détente", | ||
| "item.blast.pearl_bomb": "Bombe de perle", |
Member
There was a problem hiding this comment.
I feel like "Bombe Perle" sounds a little nicer but I'm not sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the file wasn't completed when compared to the other json files.