Skip to content

Conversation

@paulnoirel
Copy link
Contributor

Description

For FEED-1387 (request for Amazon)

  • Add search by name to get_catalog_slice()
  • Add get_catalog_slices()

Fixes # 0 (issue)

Type of change

Please delete options that are not relevant.

  • [ X] New feature (non-breaking change which adds functionality)

All Submissions

  • [X ] Have you followed the guidelines in our Contributing document?
  • [ X] Have you provided a description?
  • [ X] Are your changes properly formatted?

New Feature Submissions

  • [ X] Does your submission pass tests?
  • [ X] Have you added thorough tests for your new feature?
  • [ X] Have you commented your code, particularly in hard-to-understand areas?
  • [ X] Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@paulnoirel paulnoirel merged commit 30910f4 into develop Feb 18, 2025
21 of 26 checks passed
@paulnoirel paulnoirel deleted the pno/get_slice_by_name branch February 18, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants