Issue 54218: Escape special characters in form field names #7193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-nicka
force-pushed
the
fb_assay_slash_54218
branch
from
6bb4988 to
c18113c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
labkey-nicka
force-pushed
the
fb_assay_slash_54218
branch
from
83b4016 to
7e7c822
Compare
labkey-nicka
force-pushed
the
fb_assay_slash_54218
branch
from
7e7c822 to
b424951
Compare
Contributor
labkey-matthewb
left a comment
labkey-matthewb
left a comment
There was a problem hiding this comment.
I think a pattern like
UploadWizardAction.getInputName(..., boolean isMultiPart)
TableViewForm.getFormFieldName(..., boolean isMultiPart)
might be cleaner than having the caller conditionally use these methods. And force the caller to always provide this parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 54218 by escaping special characters in
TableViewForminput names. This concept was first introduced with #7033 specifically forQueryUpdateForm.Related Pull Requests
Changes
QueryUpdateFormtoTableViewForm.AssayFileWriterwhen resolving properties in the file map.Tasks