Skip to content

Fix PurgeNpmAlphaVersion to not require properties used by base class #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 4 commits into from
Dec 23, 2025
Merged

Fix PurgeNpmAlphaVersion to not require properties used by base class #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e8e56b
Mark packageName and versionList as optional inputs since not needed …
labkey-susanh Dec 22, 2025
71d0545
release notes
labkey-susanh Dec 22, 2025
617bff1
update version
labkey-susanh Dec 22, 2025
71213d5
prepare for merge
labkey-susanh Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ If you are making changes to the plugins, please see the [internal docs](https:/
on how to do that, including how to develop and test locally and the versioning information.

## Release Notes
### 7.2.1
*Released* 23 December 2025
(Earliest compatible LabKey version: 25.10)
- Fix `PurgeNpmAlphaVersions` task

### 7.2.0
*Released*: 11 December 2025
Expand Down
3 changes: 3 additions & 0 deletions src/main/groovy/org/labkey/gradle/task/PurgeNpmVersions.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import org.gradle.api.DefaultTask
import org.gradle.api.GradleException
import org.gradle.api.provider.Property
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.Optional
import org.gradle.api.tasks.TaskAction
import org.labkey.gradle.util.TaskUtils

Expand All @@ -22,9 +23,11 @@ abstract class PurgeNpmVersions extends DefaultTask
private static final String VERSION_LIST_PROP = "versionList"

@Input
@Optional
final abstract Property<String> packageName = project.objects.property(String).convention((project.hasProperty(PACKAGE_NAME_PROP) ? (String) project.property(PACKAGE_NAME_PROP) : null))

@Input
@Optional
final abstract Property<String> versionList = project.objects.property(String).convention((project.hasProperty(VERSION_LIST_PROP) ? (String) project.property(VERSION_LIST_PROP) : null))

@Input
Expand Down