make file path first arg (#1) #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new: make csv file first argument instead of query, make query optional and add extra options to CLI * deps: add pytest-cov to optional dependencies
Author
|
Hey there! I was using your library looking for something lightweight to plot from csv files and I felt like passing the file path as an argument and the query as an option would make for a better interface. If you like this, I can edit the README with the new interface and/or add tests. Let me know! thanks |
Owner
|
Hi Diego,
Thank you for your contribution!
I like the changes. Please edit the README and add a test or two when you
have a chance and I will merge everything.
Cheers,
L.
…On Thu, Jan 8, 2026 at 2:41 PM Diego Quintana ***@***.***> wrote:
*diegoquintanav* left a comment (LVG77/duck-plot#1)
<#1 (comment)>
Hey there! I was using your library looking for something lightweight to
plot from csv files and I felt like passing the file path as an argument
and the query as an option would make for a better interface.
If you like this, I can edit the README with the new interface and/or add
tests. Let me know! thanks
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBOTXA42XZVQVZENAZD26T4F2XHPAVCNFSM6AAAAACRDI7FT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMRVGQZDSMJQGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new: make csv file first argument instead of query, make query optional and add extra options to CLI
deps: add pytest-cov to optional dependencies