Issue #792: Initial draft of the MDR data model requirements #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #### Org LIF | ||
|
|
||
| A model specific to the LIF adopter, seeded and reliant on references from the _Base LIF_ model (known as inclusions), and enhancements added directly by the LIF adopter (known as extensions). | ||
| A model specific to the LIF adopter, seeded and reliant on references from other _Data Models_ (_Base LIF_ (known as `Inclusions`), _Partner LIF_, or _Source Schema_), and with enhancements added directly by the LIF adopter (known as extensions). |
There was a problem hiding this comment.
I think the parenthetical for "(known as Inclusions) is in the wrong place. They're all inclusions regardless of what data model type they're being included from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Documents the requirements of the MDR Data Model, specifically the structure and transformations of the models. There is more to document, so the ADR is not in a finished state, but can be merge for a living document.
Related Issues
Closes #792
Checklist
uv run ruff check)uv run ruff format)uv run ty check)docs/and project README updated
and CHANGELOG.md entry
Type of Change
to not work as expected)
Testing
Project Area(s) Affected
Additional Notes