Skip to content

Add serde traits for presignature public data and commitment#172

Open
alfonzii wants to merge 1 commit intoLFDT-Lockness:cggmp24/mfrom
alfonzii:cggmp24/m
Open

Add serde traits for presignature public data and commitment#172
alfonzii wants to merge 1 commit intoLFDT-Lockness:cggmp24/mfrom
alfonzii:cggmp24/m

Conversation

@alfonzii
Copy link

@alfonzii alfonzii commented Feb 16, 2026

To be able to serialize presignatures as a whole also in CGGMP24, we need to derive serde traits for public data.

Copy link
Contributor

@survived survived left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting it! Due to org policies, we can only merge PR if:

Could you sign-off commits and GPG-sign them?

Also, if you want this change to be released to crates-io after this PR is merged, could you update the lib version to 0.7.0-alpha.4?

Comment on lines +195 to 196
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
pub struct PresignaturePublicData<E: Curve> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alone is not sufficient, you also need to add this attribute, otherwise derived trait impl will be unusable

Suggested change
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
pub struct PresignaturePublicData<E: Curve> {
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(bound = "")]
pub struct PresignaturePublicData<E: Curve> {


/// Presignature commitment, used to verify partial signature correctness
#[derive(Clone, Debug, PartialEq, Eq)]
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments