Add serde traits for presignature public data and commitment#172
Open
alfonzii wants to merge 1 commit intoLFDT-Lockness:cggmp24/mfrom
Open
Add serde traits for presignature public data and commitment#172alfonzii wants to merge 1 commit intoLFDT-Lockness:cggmp24/mfrom
alfonzii wants to merge 1 commit intoLFDT-Lockness:cggmp24/mfrom
Conversation
survived
reviewed
Feb 17, 2026
Contributor
survived
left a comment
There was a problem hiding this comment.
Thanks for submitting it! Due to org policies, we can only merge PR if:
- commits are signed-off (there's a failing workflow with instructions how to fix it)
- commits are GPG signed
Could you sign-off commits and GPG-sign them?
Also, if you want this change to be released to crates-io after this PR is merged, could you update the lib version to 0.7.0-alpha.4?
Comment on lines
+195
to
196
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub struct PresignaturePublicData<E: Curve> { |
Contributor
There was a problem hiding this comment.
This alone is not sufficient, you also need to add this attribute, otherwise derived trait impl will be unusable
Suggested change
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] | |
| pub struct PresignaturePublicData<E: Curve> { | |
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] | |
| #[serde(bound = "")] | |
| pub struct PresignaturePublicData<E: Curve> { |
|
|
||
| /// Presignature commitment, used to verify partial signature correctness | ||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to serialize presignatures as a whole also in CGGMP24, we need to derive serde traits for public data.