test(ui): add ui testing for the console plugin 'Policies' page #815

emmaaroche · 2025-11-17T13:28:07Z

Description

This PR adds Playwright-based UI tests for the Policies page of the Kuadrant console plugin. The tests cover creating, listing, and deleting each policy type (Auth, DNS, RateLimit, TLS) within this page and are compatible with both PatternFly v5 and v6.

UI tests for additional console plugin pages and functionality will be introduced in future PRs.

Related issue: #556

Changes

New Features

UI Testing Framework: Added pytest-playwright dependency and ui pytest marker for browser-based testing
Page Objects:
Added reusable page object classes under testsuite/page_objects/ to model the console plugin’s Policies views:
- nav_bar.py and navigator.py for console navigation
- Policy-specific page objects for the create and list pages:
  auth_policy.py, dns_policy.py, rate_limit_policy.py, tls_policy.py, along with the shared base class policies.py
Tests:
Added under testsuite/tests/singlecluster/ui/console_plugin/policies/:
- test_auth_policy.py - UI test for creating (YAML), listing, and deleting an AuthPolicy
- test_rate_limit_policy.py - UI test for creating (YAML), listing, and deleting a RateLimitPolicy
- test_dns_policy.py - UI tests for creating (form/YAML), listing, and deleting a DNSPolicy
- test_tls_policy.py - UI tests for creating (form/YAML), listing, and deleting a TLSPolicy
- conftest.py - Test configuration with browser setup, login automation, and console plugin enablement checks

Infrastructure Changes

Configuration: Updated Makefile and config/settings.local.yaml.tpl to support UI testing

Verification steps

Run the UI tests:

make ui

Run the UI tests and see browser session happening during the test:

 make ui flags="--headed --slowmo 1000"

These tests require:

OpenShift cluster (tested on OCP 4.17 through to 4.20) with the Kuadrant / RHCL console plugin enabled
Valid HTPasswd credentials configured
Browser dependencies installed via playwright install

testsuite/tests/singlecluster/ui/console_plugin/policies/conftest.py

testsuite/tests/singlecluster/ui/console_plugin/policies/test_dns_policy.py

Makefile

azgabur

WIP review, will check test cases later

testsuite/tests/singlecluster/ui/console_plugin/policies/conftest.py

Makefile

testsuite/tests/singlecluster/ui/console_plugin/policies/conftest.py

testsuite/page_objects/policies/auth_policy.py

testsuite/page_objects/policies/dns_policy.py

testsuite/page_objects/policies/policies.py

testsuite/tests/singlecluster/ui/console_plugin/policies/test_auth_policy.py

testsuite/page_objects/policies/auth_policy.py

testsuite/page_objects/policies/policies_list_page.py

testsuite/page_objects/policies/dns_policy.py

testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_tls_policy.py

testsuite/page_objects/policies/rate_limit_policy.py

testsuite/page_objects/policies/auth_policy.py

testsuite/tests/singlecluster/ui/console_plugin/policies/test_rate_limit_policy.py

Makefile

testsuite/page_objects/policies/policies_list_page.py

testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_dns_policy.py

azgabur

DnsPolicy and TlsPolicy tests require separate Gateway as they attach to a specific Gateway + TlsPolicy needs different listener. I would separate the ui tests similrly that is now in singlecluster module. gateway tests which test dns/tls and gateway attachment tests, these should have gateway module scoped. And others which can keep the session gateway created in tests/conftest.py This can be achieved just by having module gateway with conftest simillar to that in gateway/conftest in singlecluster. This can also be a root problem of the errors Alex seen #815 (comment)

azgabur · 2025-12-02T15:12:48Z

Makefile

 	@ touch .make-poetry-sync-no-dev

+.make-playwright-install: .make-poetry-sync-no-dev
+	@if poetry run playwright install --check >/dev/null 2>&1; then \


Hmm 🤔

error: unknown option '--check'

My mistake, I thought that flag checked whether the Playwright browsers were already installed, and since make ui didn’t throw errors I assumed it worked 😅 I’ve removed it now 👍

azgabur · 2025-12-02T16:06:47Z

testsuite/tests/singlecluster/ui/console_plugin/policies/conftest.py

+@pytest.fixture(scope="module")
+def authorization():
+    """Override parent authorization fixture - prevents unnecessary resource creation"""
+    return None
+
+
+@pytest.fixture(scope="module")
+def rate_limit():
+    """Override parent rate limit fixture- prevents unnecessary resource creation"""
+    return None


I think instead of removing these fixtures you can override commit fixture to not do anything. You can than later use these fixtures in tests.

azgabur · 2025-12-02T16:23:48Z

testsuite/tests/singlecluster/ui/console_plugin/policies/test_auth_policy.py

+    assert list_page.is_policy_listed(policy_name), f"AuthPolicy '{policy_name}' not found in list"
+
+    # Verify AuthPolicy created via UI enforces as expected
+    response = client.get("/get")


Missing wait_for_ready before attempting request. Maybe the wait can be UI-based? There are columns "Accepted" and "Enforced".

The policy is already being waited on inside create_yaml():

self.page.wait_for_selector("text=AuthPolicy has been accepted", timeout=60000)

If you would like I can add a wait for enforced too?

Update - in new changes i have added a wait for enforced too

testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_dns_policy.py

azgabur · 2025-12-02T16:29:52Z

testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_tls_policy.py

+
+
+@pytest.mark.parametrize("create_method", ["form", "yaml"])
+def test_tls_policy_ui(request, navigator, cluster, blame, gateway, cluster_issuer, create_method, client):


TlsPolicy tests requires presence of DnsPolicy as well. As well has Gateway having TLS listener. These are missing in this test. These could be made using API

testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_dns_policy.py

testsuite/page_objects/policies/tls_policy.py

Signed-off-by: emmaaroche <eroche@redhat.com>

averevki

LGTM, nice pages abstraction 👍

emmaaroche requested review from averevki and azgabur November 17, 2025 13:28

emmaaroche self-assigned this Nov 17, 2025

emmaaroche added the Test case New test case label Nov 17, 2025

emmaaroche mentioned this pull request Nov 18, 2025

Dynamic Plugin UI end-to-end test #556

Open

14 tasks

crstrn13 reviewed Nov 18, 2025

View reviewed changes

testsuite/tests/singlecluster/ui/console_plugin/policies/conftest.py Show resolved Hide resolved

testsuite/tests/singlecluster/ui/console_plugin/policies/test_dns_policy.py Outdated Show resolved Hide resolved

crstrn13 reviewed Nov 18, 2025

View reviewed changes

Makefile Outdated Show resolved Hide resolved

emmaaroche force-pushed the add-ui-testing branch from 468bdf7 to 19edea7 Compare November 19, 2025 12:30

azgabur reviewed Nov 19, 2025

View reviewed changes

emmaaroche force-pushed the add-ui-testing branch from 19edea7 to 0e1f739 Compare November 19, 2025 17:20

averevki reviewed Nov 20, 2025

View reviewed changes

emmaaroche force-pushed the add-ui-testing branch from 0e1f739 to 1e16b14 Compare November 21, 2025 13:42

emmaaroche requested review from averevki, azgabur and crstrn13 November 21, 2025 13:43

averevki reviewed Nov 24, 2025

View reviewed changes

emmaaroche force-pushed the add-ui-testing branch from 1e16b14 to 6162e37 Compare November 25, 2025 11:05

emmaaroche requested a review from averevki November 25, 2025 11:15

emmaaroche force-pushed the add-ui-testing branch from 6162e37 to 2af45e9 Compare November 26, 2025 13:03

emmaaroche mentioned this pull request Nov 27, 2025

ci: reorganize dockerfiles and add UI image #820

Open

averevki reviewed Nov 28, 2025

View reviewed changes

Makefile Outdated Show resolved Hide resolved

testsuite/page_objects/policies/policies_list_page.py Show resolved Hide resolved

testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_dns_policy.py Show resolved Hide resolved

emmaaroche force-pushed the add-ui-testing branch from 2af45e9 to 82a8003 Compare December 1, 2025 14:03

azgabur reviewed Dec 2, 2025

View reviewed changes

emmaaroche force-pushed the add-ui-testing branch from 82a8003 to 68c7124 Compare December 5, 2025 16:27

emmaaroche requested review from averevki and azgabur December 5, 2025 16:50

averevki reviewed Dec 8, 2025

View reviewed changes

testsuite/tests/singlecluster/ui/console_plugin/policies/dnstls/test_dns_policy.py Outdated Show resolved Hide resolved

testsuite/page_objects/policies/tls_policy.py Outdated Show resolved Hide resolved

emmaaroche force-pushed the add-ui-testing branch from 68c7124 to 9e8a99a Compare December 9, 2025 15:09

emmaaroche force-pushed the add-ui-testing branch from 9e8a99a to b44fe87 Compare December 18, 2025 12:46

test(ui): add ui testing for the console plugin Policies page

ff26312

Signed-off-by: emmaaroche <eroche@redhat.com>

emmaaroche force-pushed the add-ui-testing branch from b44fe87 to ff26312 Compare January 7, 2026 14:00

emmaaroche requested a review from averevki January 7, 2026 14:02

averevki approved these changes Jan 7, 2026

View reviewed changes



		@pytest.mark.parametrize("create_method", ["form", "yaml"])
		def test_tls_policy_ui(request, navigator, cluster, blame, gateway, cluster_issuer, create_method, client):

test(ui): add ui testing for the console plugin 'Policies' page #815

Are you sure you want to change the base?

test(ui): add ui testing for the console plugin 'Policies' page #815

Uh oh!

Conversation

emmaaroche commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

New Features

Infrastructure Changes

Verification steps

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azgabur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azgabur left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azgabur Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

emmaaroche Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

azgabur Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

azgabur Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

emmaaroche Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

emmaaroche Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azgabur Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

averevki left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

emmaaroche commented Nov 17, 2025 •

edited

Loading

azgabur left a comment •

edited

Loading