feat: Add test for DNSRecord with delegate=false #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabikova
force-pushed
the
feature/issue-784-dns-delegate-test
branch
2 times, most recently
from
1a41d96 to
048703f
Compare
averevki
reviewed
Nov 18, 2025
testsuite/tests/singlecluster/gateway/dnspolicy/test_dnsrecord_delegate_false.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/dnspolicy/test_dnsrecord_delegate_false.py
Outdated
Show resolved
Hide resolved
azgabur
reviewed
Nov 19, 2025
testsuite/tests/singlecluster/gateway/dnspolicy/test_dnsrecord_delegate_false.py
Outdated
Show resolved
Hide resolved
fabikova
force-pushed
the
feature/issue-784-dns-delegate-test
branch
from
048703f to
3f27811
Compare
fabikova
changed the title
fabikova
force-pushed
the
feature/issue-784-dns-delegate-test
branch
3 times, most recently
from
71cb638 to
56f88be
Compare
averevki
reviewed
Dec 11, 2025
testsuite/tests/singlecluster/gateway/dnspolicy/test_dnsrecord_delegate_false.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/dnspolicy/test_dnsrecord_delegate_false.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/dnspolicy/test_dnsrecord_delegate_false.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/dnspolicy/test_dnsrecord_delegate_false.py
Outdated
Show resolved
Hide resolved
Comment on lines
47
to
49
| @backoff.on_exception( | ||
| backoff.fibo, (dns.resolver.NXDOMAIN, dns.resolver.NoAnswer, dns.exception.Timeout), max_time=120 | ||
| ) |
Contributor
There was a problem hiding this comment.
why do you need backoff here? Your test worked without backoff on all providers for me when I tried
Contributor
Author
There was a problem hiding this comment.
yes, it works without backoff. I originally added it to prevent potential flaky failures caused by DNS propagation latency, just to ensure the test doesn't fail if resolution lags behind the status update. However, since I haven't seen any failures locally, I'll remove it as you suggested.
Contributor
There was a problem hiding this comment.
Record should be ready when it reports that Provider ensured the dns record. Any irregularities here may be an indication that something doesn't work as intended
+ any extra code slows down the testsuite. We try not to add extra line to cover any possible outcome
Signed-off-by: Martina Fabikova <mfabikov@redhat.com>
fabikova
force-pushed
the
feature/issue-784-dns-delegate-test
branch
from
56f88be to
79c3a81
Compare
averevki
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for the DNSRecord resource, covering the delegate=false scenario as requested in issue #784.
The test verifies that a DNSRecord (not managed by a DNSPolicy) configured with:
can successfully create and publish its DNS entries to the external provider.
The test validates this in two steps: