Made the result idxs and dists datatypes selectable#161
Open
n6171028 wants to merge 1 commit intoKristofferC:masterfrom
Open
Made the result idxs and dists datatypes selectable#161n6171028 wants to merge 1 commit intoKristofferC:masterfrom
n6171028 wants to merge 1 commit intoKristofferC:masterfrom
Conversation
Owner
|
Sorry, I merged some stuff that conflicts with this. For the distances, I think it is ok to do what we currently do and let the input points determine the distance type. Is it really needed to get the distances in e.g. a lower precision than what you tree is built with? For the integer type I agree it is a good idea to specify it. An alternative to this is to reduce the integer type to the smallest that could fit any index into the input data set. That would make things type unstable though.. But maybe with union splitting it is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset enables the user to choose the return data type from the knn function