Skip to content

Conversation

@zhaixianyu
Copy link
Contributor

MixinBucketItem doesn't need it to do anything.
The components of the items in the container should be loaded before the server starts, while the crafting table needs to be sooner

MixinBucketItem 不需要它做任何事情。
容器中物品的组件应该在服务器启动之前加载,而合成表需要更早

@MylesGit
Copy link

Created a fork to implement this pull request. I made sure to credit you in the repository @zhaixianyu . I appreciate the fix!

@KrisCris
Copy link
Owner

Created a fork to implement this pull request. I made sure to credit you in the repository @zhaixianyu . I appreciate the fix!

Thanks, Myles. I will link your repo in the readme!

Copy link
Owner

@KrisCris KrisCris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@KrisCris KrisCris merged commit d0c9ca4 into KrisCris:latest Jun 28, 2025
2 checks passed
@MylesGit
Copy link

@KrisCris Does this mean the repo is now maintained again? If so I'll discontinue mine and make some PRs to implement bug fixes into this repo.

@KrisCris
Copy link
Owner

KrisCris commented Jun 28, 2025

@KrisCris Does this mean the repo is now maintained again? If so I'll discontinue mine and make some PRs to implement bug fixes into this repo.

Well, yes and no. I will accept PRs if there are any, but I probably won't be able to add new features.

If you have plans to continue maintaining and developing the mod on your fork, I am happy to see it!

Otherwise, sure, I can merge your contributions! Or if you prefer to directly maintain this repo, I can add you as collaborators.

@MylesGit
Copy link

For now, I'll maintain my fork separately.

Currently planning on dropping support for Mandarin, making the configuration more readable / editable, and adding features (ClothConfig & ModMenu support).

I'll end up changing the mod name "AllStackableContinued", as "AllStackable" is not going to abandoned or at the very least, look abandoned; and I don't want to confuse users.

I appreciate you for making the mod in the first place!
I've made sure to credit you in the Git repository and on Modrinth. Feel free to reach out if you ever want me to change / improve credit.

@KrisCris
Copy link
Owner

For now, I'll maintain my fork separately.

Currently planning on dropping support for Mandarin, making the configuration more readable / editable, and adding features (ClothConfig & ModMenu support).

I'll end up changing the mod name "AllStackableContinued", as "AllStackable" is not going to abandoned or at the very least, look abandoned; and I don't want to confuse users.

I appreciate you for making the mod in the first place!

I've made sure to credit you in the Git repository and on Modrinth. Feel free to reach out if you ever want me to change / improve credit.

That's great, thank you for maintaining it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants