Open
Conversation
I've modified the code to handle MINGW environments on Windows. Here are the key changes: In the setup_platform method: Added checks for MSYSTEM and MINGW_PREFIX environment variables If MINGW is detected, it sets up paths using the MINGW_PREFIX: Sets LIBRARY_PATH to point to the MINGW ngspice DLL Sets SPICE_LIB_DIR to the MINGW scripts directory Sets NGSPICE_LIBRARY_PATH to the specific MINGW ngspice DLL The code maintains the original Windows paths as a fallback when MINGW is not detected. The _load_library method was updated to only set the default Windows SPICE_LIB_DIR if: The environment variable isn't already set NGSPICE_PATH exists (indicating we're using the original Windows path) This way, when running in a MINGW environment, it will automatically detect and use the MINGW-installed ngspice, but will fall back to the original behavior in standard Windows environments. You won't need to manually set the environment variables anymore when using MINGW.
I did missmanage some things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
setup_platformmethod in thePySpice/Spice/NgSpice/Shared.pyfile. The change modifies the library path for the MINGW environment.PySpice/Spice/NgSpice/Shared.py: Updated theLIBRARY_PATHto uselibngspice-0{}.dllinstead oflibngspice{}.dllin the MINGW paths.