Skip to content

Conversation

@Krealle
Copy link
Owner

@Krealle Krealle commented Jul 5, 2025

Related to #186

Implements the structure needed for non Mainline flavors.

Currently MoP is the focus.

@Krealle Krealle added the feature New feature or request label Jul 5, 2025
@wadixx
Copy link

wadixx commented Jul 5, 2025

Thank you for your contribution. Will you also support Anniversary?

@wadixx
Copy link

wadixx commented Jul 12, 2025

Hello. Thank you for this. I tried addo you shared on discord and received 2 errors because of edit mode. Surprisingly no api errors.

1st Error
8x ...rfaceCell_UnitFrames/UnitFrames/EditMode.lua:443: table index is nil

2nd Error
1x Cell_UnitFrames/Core/SlashCommands.lua:23: attempt to call method 'EditMode' (a nil value)
[Cell_UnitFrames/Core/SlashCommands.lua]:23: in function '?'
[Blizzard_ChatFrameBase/Classic/ChatFrame.lua]:5057: in function 'ChatEdit_ParseText'
[Blizzard_ChatFrameBase/Classic/ChatFrame.lua]:4709: in function 'ChatEdit_SendText'
[Blizzard_ChatFrameBase/Classic/ChatFrame.lua]:4745: in function 'ChatEdit_OnEnterPressed'
[*ChatFrame.xml:120_OnEnterPressed]:1: in function <[string "*ChatFrame.xml:120_OnEnterPressed"]:1>

Locals:
msg = "edit"
editbox = ChatFrame1EditBox {
tabCompleteTableIndex = 1
setText = 0
added = true
chatFrame = ChatFrame1 {
}
addSpaceToAutoComplete = true
command = "/cuf"
chatLanguage = "Orcish"
headerSuffix = ChatFrame1EditBoxHeaderSuffix {
}
autoCompleteParams =

{
}
autoCompleteXOffset = 35
disallowAutoComplete = false
header = ChatFrame1EditBoxHeader {
}
addHighlightedText = true
prompt = ChatFrame1EditBoxPrompt {
}
text = ""
}
command = "edit"
rest = ""
(*temporary) = nil
(*temporary) =
{
}
(*temporary) = "attempt to call method 'EditMode' (a nil value)"
CUF =
{
Handler =
{
}
vars =
{
}
Mixin =
{
}
uFuncs =
{
}
API =
{
}
version = 24
Util =
{
}
Defaults =
{
}
Compat =
{
}
DB =
{
}
constants =
{
}
mainFrame = CUFMainFrame {
}
ImportExport =
{
}
Menu =
{
}
Cell =
{
}
DebugWindow =
{
}
PixelPerfect =
{
}
HelpTips =
{
}
Debug =
{
}
L =
{
}
unitButtons =
{
}
Builder =
{
}
widgets =
{
}
}
Debug =
{
}

@Krealle
Copy link
Owner Author

Krealle commented Jul 12, 2025

Hello. Thank you for this. I tried addo you shared on discord and received 2 errors because of edit mode. Surprisingly no api errors.

Deprecated code causing issues, classic. Uploaded a new version https://discord.com/channels/1062050991664529498/1278371752405373000/1393705675686805705

@wadixx
Copy link

wadixx commented Jul 12, 2025

Hello. Thank you for this. I tried addo you shared on discord and received 2 errors because of edit mode. Surprisingly no api errors.

Deprecated code causing issues, classic. Uploaded a new version https://discord.com/channels/1062050991664529498/1278371752405373000/1393705675686805705

Works perfect!

@wadixx
Copy link

wadixx commented Jul 13, 2025

I tested almost all functions of addon. Only found 2 bugs.

  1. In Unit Frames options Edit Mode and Unit Frames texts look on top of each other. See attached screenshot.
  2. Addon doesn't hide combo points from blizzard unit frames although player and target frames are hidden via Blizzard Frames option in general settings.
image

@wadixx
Copy link

wadixx commented Jul 13, 2025

Hide Buff Frame doesn't hide weapon enchants as well.

@Krealle
Copy link
Owner Author

Krealle commented Jul 20, 2025

Hide Buff Frame doesn't hide weapon enchants as well.

I can't really see why this would be, can you do /framestack and see what the frame is called?

@wadixx
Copy link

wadixx commented Jul 20, 2025

I believe it is TemporaryEnchantFrame

image

@Krealle Krealle moved this to In progress in Cell_UnitFrames Jul 26, 2025
@wadixx
Copy link

wadixx commented Aug 1, 2025

1.4.69 version in Discord didn't fix temporary enchants. It fixed combo points tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants