Become compatible with React Native v0.59#19
Open
swansontec wants to merge 1 commit intoKrazyLabs:masterfrom
Open
Become compatible with React Native v0.59#19swansontec wants to merge 1 commit intoKrazyLabs:masterfrom
swansontec wants to merge 1 commit intoKrazyLabs:masterfrom
Conversation
React Native v0.59 uses a new version of the Android SDK that is incompatible with the one in this library, producing build failures. Using the `rootProject` setting means this library will automatically work with a broad range of React Native versions, so this shouldn't be a breaking change.
therealravitej
approved these changes
Jun 3, 2019
therealravitej
left a comment
therealravitej
left a comment
There was a problem hiding this comment.
This will prevent build failures.
|
can someone to merge this PR ? |
|
Please merge this PR asap? @therealravitej @seantimm I'm getting the same error of #18 and this PR fix this |
Contributor
|
|
|
abandoned package? |
|
Possible workaround facebook/react-native#19239 (comment) |
|
From RN 0.60 you can use Linking.openSettings() which does the same thing as this lib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Native v0.59 uses a new version of the Android SDK that is incompatible with the one in this library, producing build failures. Using the
rootProjectsetting means this library will automatically work with a broad range of React Native versions, so this shouldn't be a breaking change.