Open
Conversation
* validate operation.input first before validate against it s3/listBuckets does not accept any input.validator * refix S3 fixes path: if path=="" we need to restore path="/" * return raw body reader if operation output expects blob or streaming content
|
Vladislav Grubov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered that operations without empty description of
operation.inputdoes not work at all. I've addedifintoaws/init.luaandaws/request/build.luas3_patch(aws/init.lua) seems to be not quite well written. When we changerequest.hostwe should changerequest.headers.Hostas well, because of the signature. Also, operations such aslistObjectsV2and other meta operations requires non-empty path.The last part is not quite good :( It would be nice if we could parse xml output into Lua tables, we have
operation.outputdescriptions for it. To do that we need to distinguish streaming content and API responses.Streaming content (
GetObjectmostly, maybeGetObjectTorrent) it would be better to not read entire body into Lua memory, but providebody_readerfromresty.httpinstead. Although I'm not sure that this behaviour should be fixed the way I did itP.S. raw-api contains 17
"streaming":truelines, but necessarily all of the Outputs