Missing "=" for forum on buildUrl function#55
Open
jamierichsmith wants to merge 1 commit intoKnpLabs:masterfrom
Open
Missing "=" for forum on buildUrl function#55jamierichsmith wants to merge 1 commit intoKnpLabs:masterfrom
jamierichsmith wants to merge 1 commit intoKnpLabs:masterfrom
Conversation
In the buildUrl function, the sprintf is missing the "=" for the "forum=" parameter
weaverryan
approved these changes
Jan 18, 2023
Contributor
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Wow, a very old mistake. Looks good to me, but I don't have access to merge this :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the buildUrl function, the sprintf is missing the "=" for the "forum=" parameter