change the version of Android SDK and NDK #36
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
we apply a PR(#35, #35), which change the params of links.
but it can not apply the 16KB page size of Google, So we change the version of Android SDK and NDK.
we make a test of this changes, it can apply the 16KB Page size of Google,
Notice: you need to update the Android SDK and NDK in your PC, and it will affect your local build environment.
please help for update this PR
thanks a lot.
中文说明:
您好!
我们提交过一个PR(#35),主要用来适配Google在Android35上要求的16KB Page size。但是它需要和编译环境配合才有效果。
因此我们在本次PR中修改了AndroidSDK和NDK的版本,因为NDK的版本高于r28,默认支持16KB Page Size的要求,所以不再需要
修改links的参数。为此我们revert 了上一个PR(#35)中修改的内容。总之,如果想适配Google在Android35上要求的16KB Page size,只更新此PR就可以。
注意:因为修改了Android SDK 和NDK版本,您需要更新它们,这将会影响您本地的编译环境。
请帮忙合并PR
谢谢!