Fix identity comparison (is not) to value comparison (!=)#557
Open
Mr-Neutr0n wants to merge 1 commit intoKlingAIResearch:mainfrom
Open
Fix identity comparison (is not) to value comparison (!=)#557Mr-Neutr0n wants to merge 1 commit intoKlingAIResearch:mainfrom
Mr-Neutr0n wants to merge 1 commit intoKlingAIResearch:mainfrom
Conversation
In `execute()`, two comparisons used `is not` instead of `!=` to compare integer values. In CPython, integers outside the cached range [-5, 256] are not guaranteed to be the same object, so `is not` can return True even when the values are equal. This causes incorrect frame count adjustment for videos with more than 256 frames, leading to silent output truncation. Replace `is not` with `!=` for correct value-based comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
src/live_portrait_pipeline.py, theexecute()method usesis notfor integer comparisons on two lines (lines 156 and 199). This performs an identity check rather than a value check. In CPython, integers outside the internally cached range of[-5, 256]are not guaranteed to be the same object, sois notcan incorrectly returnTrueeven when the values are equal.This causes incorrect frame count adjustment for videos with more than 256 frames, leading to silent output truncation.
Before:
After:
Test plan