Skip to content

Conversation

@Pansysk75
Copy link
Contributor

Previously, if a submission happened on a non-existent project, the CheckForTooManyBuilds() would result in a 500 http code, which caused me some confusion.

Thanks!

Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply relocating the check is not a robust fix. Instead, it would be better to check the return value of $this->project->FindByName($projectname); and use $this->failProcessing() to return an appropriate error if the project does not exist.

@Pansysk75
Copy link
Contributor Author

Pansysk75 commented Dec 14, 2025

Simply relocating the check is not a robust fix. Instead, it would be better to check the return value of $this->project->FindByName($projectname); and use $this->failProcessing() to return an appropriate error if the project does not exist.

That makes sense, thank you for the feedback! I made the requested changes. Please feel free to take the wheel, as I'm not too experienced with either the CDash codebase or php.

@williamjallen williamjallen force-pushed the fix-non-existent-project branch from d48467a to d307ac3 Compare December 29, 2025 23:06
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Pansysk75, thanks for this contribution. I rebased your PR and pushed some minor changes, and will merge once CI passes.

@williamjallen williamjallen added this pull request to the merge queue Dec 29, 2025
Merged via the queue into Kitware:master with commit 4bf8fc1 Dec 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants