Skip to content

Comments

Removed dependence on environment variables by allowing variables to be set on instantiation#10

Open
itsterry wants to merge 2 commits intoKit:mainfrom
morsedigital:main
Open

Removed dependence on environment variables by allowing variables to be set on instantiation#10
itsterry wants to merge 2 commits intoKit:mainfrom
morsedigital:main

Conversation

@itsterry
Copy link

@itsterry itsterry commented Jan 4, 2023

I've made it so that you can specify client_id, client_secret, and redirect_uri at the same time as auth_token, like this:

client = InstagramBasicDisplay::Client.new(auth_token: token, 
                                           client_id: client_id, 
                                           client_secret: client_secret, 
                                           redirect_uri: redirect_uri)

This allows people to store their credentials in any of the other secure methods (Rails.application.credentials, etc)

I've also removed the bundler versioning restriction and the Ruby version restriction (they were getting a little old)

@yshmarov
Copy link

really great addition! I really prefer using rails credentials VS env vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants