Conversation
noelherrick
approved these changes
Apr 4, 2025
| * | ||
| * @return void | ||
| */ | ||
| public function testAddSubscribersToForms() |
There was a problem hiding this comment.
What value do you see with these tests as they appear to be testing whether or not the Kit API is throwing an exception vs. testing logic in this library? Or am I misunderstanding?
Contributor
Author
There was a problem hiding this comment.
The bulk API endpoints and purchases endpoints don't support using an API Key, and therefore rightly return an error - so these tests confirm that the PHP SDK throws a ClientException, which I think there's value in doing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves this reported issue, adding support for the named
apiKeyparameter on theConvertKit_APIclass constructor.Testing
Shared tests have been moved to
tests/ConvertKitAPITest.php, with bothConvertKitAPIKeyTestandConvertKitAPIOAuthtests inheriting them.These two test classes override some specific tests as required (e.g. bulk endpoints are not supported using an API Key, so tests exist in ConvertKitAPIKeyTest for these to ensure a
ClientExceptionis thrown).Checklist