Conversation
util/blas.f90 - Removed WDOT routine - Replaced calls to WDOT with calls to F90 intrinsic DOT_PRODUCT NOTE: This also has the advantage of removing the compiler warning for the computed IF statement. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
RolfSander
approved these changes
Oct 30, 2025
Contributor
RolfSander
left a comment
There was a problem hiding this comment.
Great! You can also add a checkmark to "Update obsolete fortran code,
e.g., arithmetic IF statements" in "Ideas for KPP 4.0.0".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the BLAS
WDOTfunction fromutil/blas.F90with the Fortran90 intrinsic functionDOT_PRODUCT, which does the same thing, and probably more efficiently.We have also updated a couple of calls in BLAS routine
WGESLas follows:Prior code:
New code:
As a side benefit, this PR finally removes this compiler warning, caused by a Fortran66-style IF statement in
WDOT: