This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Merged
Conversation
The test assumes 22 byte default, but had 32 because it was double-base64 encoding (once regular, and once URL-safe). Without the double encoding, the tests fail because they were expecting 32 (then 24), but the intent was URL-safe base encoding without padding. Originally based on patricksrobertson#13, but fixes the tests and padding.
Based originally on patricksrobertson#12, but modified to prevent namespace pollution of the Base58 translation module.
halostatue
force-pushed
the
modernization
branch
from
8656784 to
45ea99a
Compare
ohnit
approved these changes
Jul 16, 2024
mikestok
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Remove committed documentation
chore: Remove unnecessary configuration
chore: Fix build and dialyzer warnings
chore: mix formatter
chore: Fix urlsafe_base64/1 generation
The test assumes 22 byte default, but had 32 because it was double-base64 encoding (once regular, and once URL-safe). Without the double encoding, the tests fail because they were expecting 32 (then 24), but the intent was URL-safe base encoding without padding.
Originally based on Don't double-encode in urlsafe_base64 patricksrobertson/secure_random.ex#13, but fixes the tests and padding.
chore: Switch from Travis to GHA
feat: Add SecureRAndom.base58/1
Based originally on add ruby base58 method patricksrobertson/secure_random.ex#12, but modified to prevent namespace pollution of the Base58 translation module.
chore: Update dependencies