V17/rte migration fix #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes RTE migration from TinyMCE to TipTap for legacy files that don't have a toolbar property defined. The migration now provides default toolbar configurations and ensures all default TipTap extensions are loaded.
Key Changes:
- Added default toolbar and extension lists to handle missing toolbar configurations
- Updated migration logic to use default toolbar when none exists instead of skipping migration
- Integrated LocalLinkProcessor in RTEMapper to process local links during import
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| RTEMapper.cs | Added LocalLinkProcessor integration and GetImportValueAsync override to process local links in RTE markup during import |
| RichTextEditorMigratingSerializer.cs | Added default toolbar and extensions lists, updated migration logic to handle missing toolbar by using defaults instead of skipping |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uSync.Core/DataTypes/DataTypeSerializers/RichTextEditorMigratingSerializer.cs
Outdated
Show resolved
Hide resolved
uSync.Core/DataTypes/DataTypeSerializers/RichTextEditorMigratingSerializer.cs
Outdated
Show resolved
Hide resolved
uSync.Core/DataTypes/DataTypeSerializers/RichTextEditorMigratingSerializer.cs
Show resolved
Hide resolved
uSync.Core/DataTypes/DataTypeSerializers/RichTextEditorMigratingSerializer.cs
Show resolved
Hide resolved
uSync.Core/DataTypes/DataTypeSerializers/RichTextEditorMigratingSerializer.cs
Outdated
Show resolved
Hide resolved
uSync.Core/DataTypes/DataTypeSerializers/RichTextEditorMigratingSerializer.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that the RTE migration from tinyMCE to TipTap doesn't always fire on legacy files (when the legacy file doesn't have a 'toolbar'.
RTE Local links updated to match some of the v17.0.1 code.