Skip to content

Conversation

@vipinkattungal
Copy link

ruby square progarame

@jikkujose
Copy link
Member

  • Fix typos in commit message
  • Place your solution in corresponding directory, rename the file to problem index.

sl.times do
puts val
end
print '#' * hash
Copy link
Member

@jikkujose jikkujose Aug 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplication of a previous line; perhaps try to make it a method & call it instead. Also make sure every variable has names that corresponds to the domain. For instance, sl or val may not be immediately obvious to what you were intending.

Note: The code is actually very good, I am actually very happy to see it. Its very simple & intuitive. And also without using any conditions! Thats a very nice attribute.

@rakeshbs
Copy link
Member

  • This code is good. You can try to refactor the code into functions. The key is to write DRY code. DRY stands for Don't Repeat Yourself. For example, the code to print first and last line can be refactored into a function because they do the same thing.
  • Try using more readable variable names.
  • Correct the spelling errors in the code and the commit message.

@vipinkattungal
Copy link
Author

thank u broozz

@jikkujose
Copy link
Member

jikkujose commented Sep 2, 2016

Consider writing every message/communication in the project in proper English. Will help others who may collaborate with you without the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants