-
Notifications
You must be signed in to change notification settings - Fork 3
ruby square progarme created #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vipinkattungal
Are you sure you want to change the base?
ruby square progarme created #2
Conversation
|
01-lets_get_started/01.rb
Outdated
| sl.times do | ||
| puts val | ||
| end | ||
| print '#' * hash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a duplication of a previous line; perhaps try to make it a method & call it instead. Also make sure every variable has names that corresponds to the domain. For instance, sl or val may not be immediately obvious to what you were intending.
Note: The code is actually very good, I am actually very happy to see it. Its very simple & intuitive. And also without using any conditions! Thats a very nice attribute.
|
|
thank u broozz |
|
Consider writing every message/communication in the project in proper English. Will help others who may collaborate with you without the context. |
ruby square progarame