fix bus signal chevrons issue in https://github.com/KenKundert/psf_utils/pull/23 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs (like < and >) in the VALUE section (e.g., I48.LOGIC_OUT\<3\>), but the TRACE section and the internal signal names use the unescaped version (I48.LOGIC_OUT<3>).
circuitmuggle
changed the title
circuitmuggle
force-pushed
the
fast_read_trans_optimization
branch
from
1b66e8b to
b2dc127
Compare
Contributor
Author
|
add test case[1] bus_chevrons_tran in tox to detect such failure |
circuitmuggle
changed the title
Owner
|
Thank you. Let me know when you think things are really stable. |
Contributor
Author
|
Hi Ken, Thank you for your reply. I totally agreed with you that we should wait a while until the code is stable before releasing it to pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For bus signal, I saw the below error.
[Error] Failed to parse PSF for sweep_0.5V: 'I48.LOGIC_OUT<3>'this pull request fix this issue at row 172 of psf.py
I will add a tox test case in the future when I have bandwidth