Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds wildcard route support to the HTTP server, allowing routes ending with /* to match requests with variable-depth path segments beyond the prefix. The implementation prioritizes exact route matches over wildcard matches.
Changes:
- Modified
routeMatchto detect and handle wildcard routes (routes ending with/*) - Updated
routeFindto prioritize exact matches over wildcard matches - Added test cases for wildcard functionality and exact-match priority
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/lib/http-server/index.ts | Implements wildcard route matching logic with prefix validation, parameter capture, and prioritization of exact matches over wildcard matches |
| src/lib/http-server/index.test.ts | Adds test cases for wildcard routes, including variable-depth paths and verification that exact routes take priority over wildcards |
3340788 to
8053c1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for wildcard routes in the
KeetaNetAnchorHTTPServerclass, enabling routes to capture variable-depth path segments.Changes