Open
Conversation
sephynox
requested review from
Srayman and
rkeene
and removed request for
Srayman
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds RFC 5652-compatible signing support to the EncryptedContainer class (v3 containers), implements structured error handling via EncryptedContainerError, and enhances algorithm validation with OID normalization.
Changes:
- Introduced EncryptedContainerError class with specific error codes for better error handling
- Added v3 container format with RFC 5652 SignerInfo support for cryptographic signing
- Implemented signature verification with OID-based algorithm validation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/utils/signing.ts | Added VerifyOptions interface to make timestamp skew validation configurable |
| src/lib/utils/signing.test.ts | Added comprehensive tests for VerifyOptions parameters (maxSkewMs, referenceTime) |
| src/lib/encrypted-container.ts | Implemented v3 container format with SignerInfo, added EncryptedContainerError class, and OID validation infrastructure |
| src/lib/encrypted-container.test.ts | Added tests for EncryptedContainerError and v3 signing functionality |
…at/encrypted-container-v3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces enhancements to the EncryptedContainer class, adding RFC 5652-compatible signing support (v3 containers), structured error handling, and improved algorithm validation.