Skip to content

Conversation

@gavinevans
Copy link

Addresses metoppv#2135

Description
This PR addresses review comments made in metoppv#2135. This PR also corrects handling within the CLI if the forecast and truth parquet files are both present but don't contain the required times. In this situation, the QRF model can not be trained.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@gavinevans gavinevans changed the title Mobt 877 implement qrf 12 Updates following review Sep 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (mobt_877_implement_qrf@5d74839). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...oad_and_train_quantile_regression_random_forest.py 0.00% 8 Missing ⚠️
...r/calibration/quantile_regression_random_forest.py 0.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                    Coverage Diff                    @@
##             mobt_877_implement_qrf      #21   +/-   ##
=========================================================
  Coverage                          ?   95.60%           
=========================================================
  Files                             ?      142           
  Lines                             ?    14177           
  Branches                          ?        0           
=========================================================
  Hits                              ?    13554           
  Misses                            ?      623           
  Partials                          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kat-90 Kat-90 merged commit 38fb827 into Kat-90:mobt_877_implement_qrf Sep 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants