Skip to content

Conversation

@gavinevans
Copy link

Addresses metoppv#2135

Description
This PR:

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 14.81481% with 23 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (mobt_877_implement_qrf@1daa7d6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...oad_and_train_quantile_regression_random_forest.py 8.33% 11 Missing ⚠️
...oad_and_apply_quantile_regression_random_forest.py 12.50% 7 Missing ⚠️
improver/calibration/__init__.py 28.57% 5 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                    Coverage Diff                    @@
##             mobt_877_implement_qrf      #20   +/-   ##
=========================================================
  Coverage                          ?   95.59%           
=========================================================
  Files                             ?      142           
  Lines                             ?    14179           
  Branches                          ?        0           
=========================================================
  Hits                              ?    13554           
  Misses                            ?      625           
  Partials                          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

If None, then each tree contains the same number of samples as the total
available. The trees will therefore only differ due to the use of
bootstrapping (i.e. sampling with replacement) when creating each tree.
max_features (int | float):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it can be a string as well, but we aren't using that.

@Kat-90 Kat-90 merged commit 5d74839 into Kat-90:mobt_877_implement_qrf Sep 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants