Skip to content

Adding feature to register pixmap atoms for other compositors #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ealdwulf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding feature to register pixmap atoms for other compositors #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 68 additions & 4 deletions src/background.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
//

#include <X11/Xlib.h>
#include <X11/Xatom.h>
#include <Imlib2.h>

#include <cmath>
Expand All @@ -18,6 +19,63 @@
#include "background.h"
#include "logging.h"



int Background::setRootAtoms (Display *display, Pixmap pixmap)
{
//
// This function taken from hsetroot,
// which in turn inherits from fluxbox bsetroot.
//
// The use of Atoms makes the background play nice with xcompmgr
// compositor, which otherwise creates faulty redraw areas on the screen.
// xsetroot seems to suffer from this same issue.
//

Atom atom_root, atom_eroot, type;
unsigned char *data_root, *data_eroot;
int format;
unsigned long length, after;

atom_root = XInternAtom (display, "_XROOTMAP_ID", True);
atom_eroot = XInternAtom (display, "ESETROOT_PMAP_ID", True);

// doing this to clean up after old background
if (atom_root != None && atom_eroot != None)
{
XGetWindowProperty (display, RootWindow (display, screen),
atom_root, 0L, 1L, False, AnyPropertyType,
&type, &format, &length, &after, &data_root);
if (type == XA_PIXMAP)
{
XGetWindowProperty (display, RootWindow (display, screen),
atom_eroot, 0L, 1L, False, AnyPropertyType,
&type, &format, &length, &after, &data_eroot);
if (data_root && data_eroot && type == XA_PIXMAP &&
*((Pixmap *) data_root) == *((Pixmap *) data_eroot))
{
XKillClient (display, *((Pixmap *) data_root));
}
}
}

atom_root = XInternAtom (display, "_XROOTPMAP_ID", False);
atom_eroot = XInternAtom (display, "ESETROOT_PMAP_ID", False);

if (atom_root == None || atom_eroot == None)
return 0;

// setting new background atoms
XChangeProperty (display, RootWindow (display, screen),
atom_root, XA_PIXMAP, 32, PropModeReplace,
(unsigned char *) &pixmap, 1);
XChangeProperty (display, RootWindow (display, screen), atom_eroot,
XA_PIXMAP, 32, PropModeReplace, (unsigned char *) &pixmap,
1);

return 1;
}

Background::Background (Configuration *loaded_conf)
{
running = false;
Expand All @@ -30,8 +88,6 @@ Background::~Background (void)

bool Background::setup(Display *display)
{
int i, screen;

// Setup X resources
screen = DefaultScreen (display);
vis = DefaultVisual (display, screen);
Expand Down Expand Up @@ -135,20 +191,28 @@ bool Background::load (Display *display)
imlib_render_image_on_drawable(0, 0);
imlib_context_set_drawable(pmap);
imlib_render_image_on_drawable(0, 0);
XSetWindowBackgroundPixmap(display, root, pmap);

// Apply the background to the root window
// so it stays permanently even if kdesk quits (-w parameter)

setRootAtoms(display, pmap);

XKillClient(display, AllTemporary);
XSetCloseDownMode(display, RetainTemporary);

XSetWindowBackgroundPixmap(display, root, pmap);

XClearWindow (display, root);
XFlush (display);
XSync(display, False);

// Free imlib and Xlib image resources
imlib_context_set_image(buffer);
imlib_free_image();
imlib_context_set_image(image);
imlib_free_image();

XFreePixmap(display, pmap);
XFreePixmap(display, pmap);

bsuccess = true;
log1 ("desktop background created successfully", image);
Expand Down
4 changes: 3 additions & 1 deletion src/background.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ class Background

public:
bool running;
int screen;

public:
Background (Configuration *loaded_conf);
virtual ~Background (void);


int setRootAtoms (Display *display, Pixmap pixmap);
bool setup (Display *display);
bool load (Display *display);
bool draw (Display *display);
Expand Down