i18n support & Japanese translation#397
Open
japonophile wants to merge 7 commits intoKanoComputing:jessiefrom
Open
i18n support & Japanese translation#397japonophile wants to merge 7 commits intoKanoComputing:jessiefrom
japonophile wants to merge 7 commits intoKanoComputing:jessiefrom
Conversation
Contributor
|
Thanks for this @japonophile! We're going to wait a while before merging this one as all the apps which depend on it will need testing, so we want to merge it at the start of a release cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds i18n (internationalization) support to the Kano profile app, including registration to Kano World.
Followed the same guidelines as in kano-greeter (see TRANSLATION.md).
The original code was already i18n-aware so the effort was minimum (just a few fixes here and there).
Also added Japanese translation, as an example.
I copied all files and tested it on my Kano after switching language to Japanese (see http://www.rs-online.com/designspark/electronics/knowledge-item/JPN-raspberry-pi-Japanese-version for details).
Let's share Kano awesomeness with non-English speaking children!