Additional Features for Windows OS #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
July 15, 2020 02:33
dumb thing that I deleted
Adding params variable will also make it simpler to add more arguments when the time comes. In this commit, also supplied paths for different uses of such parameters
Next should be usage for the other parameters
The smart description sense fixed an issue where typing "create "my repo" -d -p" (essentially not providing a description even though the tag is used) wrote "-p" (in this case) as the description. A helper method is_tag(tag, dict) was created to see if the added description is a tag. Thus, you cannot have tags as descriptions
It works! choose.py correctly passes the arguments to remote.py and remote.py correctly pushes to GitHub. Next on the list is to integrate local.py. Also, fixed in issue in remote.py where initializing the README.md file didn't create a title, rather plain text, due to a syntax error.
Capitalized some things and added some comments. Deleted some no longer needed files
Still need to work on exiting batch scripts in the right directories. Also need to add usage for remove command
I'm stupid. Guess how I found out this was a problem
Fixed an issue where, after launching create or remove, cmd would exit in path of batch script instead of the current working directory. Add usage for remove command and fixed readme accordingly
Also commited mid sentence of remove.py, so that's why that is part of this commit :)
My stupid head forget to add a sys.exit in remote.py after block of code that creates and inits a repo. As you can imagine, the bug caused the script to initialize a whole new repo in the current directory. This commit is just so we know everything is ok at this point. Also, I started the code for deleting files (which I was testing). Nearly complete
Fixed a logic error with creating directories and changing into them. Added a couple TODOs of what needs to be developed later, it's like 1 am now. Removing files locally is EXTREMELY buggy right now, but I know what's going on it's just writing the code to fix that, which we'll hopefully see in the next commit. Ok, sleep's calling
Deletes all files in a local repository correctly, displaying the relative path of each deleted file and directory. With that, this pull is basically done! Just have to add finishing touches in the form of neater code, colored output (yay!), better comments, and more try/except handling for clearer user error reports
Used colorama module to add some colour to the output, green when stuff is created and red when asking to destroy repos. Also added some comments to make it easier to understand. That pretty much finished output. Next is to refactor some variables and method names to make it more readable. After that I should be done and ready to issue a pull request. But on that note, I'll need to update the File structure too to make it more even. And add an extra readme. Thanks for reading this commit description. If you're seeing this, you're awesome! :)
Final commit. Cleaned code and refactored some variables, cleaned output. Reworked file structure and added additional README for more . . . central usage.
|
@Red-CS your changes and new feature for the win OSlooks great. Looking forward for Kalle to Merge your changes |
Author
|
@shiva-kumar04 Thank you so much! I worked so hard to get them there. I emailed Kalle the other day so I'm still waiting for a response. Thank you so much for telling me this!!! |
KalleHallden
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Kalle,
Issuing this pull request to add some vital features (for Windows, since I don't run Mac). I'll explain what I've added from most important to least in a general manner:
Now you can create repositories that have longer names/spaces. By typing
You are still able to initialize remote and local repositories.
Taking advantage of the GitHub API, I've made it so you can add descriptions too. Additionally, you can set repos to public or private. It works similarly to committing with git. Typing -d or --description and a description (can be in quotes for longer descriptions) or -p/--private to set a repo as private. There are more tags, but they are for ease of use (auto confirm to create repo, create local repo, general help or help on a tag). To see a full list of commands and tags, just type "create" or "remove" for usage and optional parameters of each. I can add that usage as a markdown file or something if you'd like, too. Lastly, I made the code more dynamic so people can add more tags if they wanted to more easily.
When you create a repo, it says so in green. When confirming you want to delete a repo, it does so in red. Not necessary, but I thought it was a nice touch.