Skip to content

Comments

Supervised benchmark et al.#50

Merged
JLrumberger merged 135 commits intomainfrom
supervised_benchmark
Oct 20, 2025
Merged

Supervised benchmark et al.#50
JLrumberger merged 135 commits intomainfrom
supervised_benchmark

Conversation

@fabianreith
Copy link
Collaborator


name: Pull request
about: Write a structured pull request
title: ''
labels: ''
assignees: ''


What is the purpose of this PR?
All changes until final paper were worked on on this branch.

How did you implement your changes?
Added all relevant files and slimmed down config files to paper relevant ones.

Remaining issues
Might still rename the config file names.

@fabianreith
Copy link
Collaborator Author

fabianreith commented Sep 28, 2025

Habe die config files umbenannt. Von meiner Seite könnten wir den jetzigen Status mergen & das repo public stellen.

[Nice to have] TODOs bis zur Konferenz:

  • Add functionality
    • Add Automatic stopping into the training process
    • Are only the best model weights saved (and where)?
  • Add documentation
    • Make pip installable
    • Add tutorial Jupyter notebooks

Copy link
Collaborator

@JLrumberger JLrumberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

scale=config.data.scale,
size=config.data.get("size", 256),)
# Setup validation dataset and DataLoader
# base_dataset = TissueNet(path=config.data_path,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be deleted.

@JLrumberger JLrumberger merged commit c3b9a94 into main Oct 20, 2025
7 checks passed
@JLrumberger JLrumberger deleted the supervised_benchmark branch October 20, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants