refactor: Change ContentConfig tags type from []string -> Set[string]#629
Merged
BrentFarris merged 1 commit intoKaijuEngine:masterfrom Feb 16, 2026
Merged
Conversation
BrentFarris
approved these changes
Feb 16, 2026
Contributor
BrentFarris
left a comment
BrentFarris
left a comment
There was a problem hiding this comment.
Amazing! Very nice drop-in replacement for the tags, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small refactor , the main reason of changing the type from a slice to a Set is that a set is more appropriate container for tags in this context as it automatically manages the duplicate tags , O(1) lookup time to check if a content has a tag.
a set defines the intent more correctly