Open
Conversation
PeTcHeNkA
reviewed
Feb 5, 2026
Comment on lines
+164
to
+165
| if (!(e instanceof EntityLivingBase)) continue; | ||
| if (e == entity) continue; |
Contributor
There was a problem hiding this comment.
if (e == enity || !(e instanceof EntityLivingBase)) continue
PeTcHeNkA
reviewed
Feb 5, 2026
Comment on lines
+186
to
+187
| if (!(e instanceof EntityLivingBase)) continue; | ||
| if (e == entity) continue; |
Contributor
There was a problem hiding this comment.
if (e == enity || !(e instanceof EntityLivingBase)) continue
PeTcHeNkA
reviewed
Feb 5, 2026
Comment on lines
+145
to
+146
| if (!(currentEntity instanceof EntityLivingBase)) continue; | ||
| if (currentEntity == entity) continue; |
Contributor
There was a problem hiding this comment.
if (currentEntity == enity || !(currentEntity instanceof EntityLivingBase)) continue
PeTcHeNkA
reviewed
Feb 5, 2026
| if (entity instanceof EntityLivingBase && entity != npc) { | ||
| EntityLivingBase living = (EntityLivingBase) entity; | ||
| for (Entity currentEntity : entities) { | ||
| if (currentEntity instanceof EntityLivingBase && currentEntity != entity) { |
Contributor
There was a problem hiding this comment.
if (currentEntity != entity && currentEntity instanceof EntityLivingBase)
PeTcHeNkA
reviewed
Feb 5, 2026
| if (entity.isDead) continue; | ||
| for (EntityLivingBase currentEntity : entities) { | ||
| if (currentEntity == entity) continue; | ||
| if (currentEntity.isDead) continue; |
Contributor
There was a problem hiding this comment.
if (currentEntity.isDead || currentEntity == entity) continue;
PeTcHeNkA
reviewed
Feb 5, 2026
| if (entity instanceof EntityLivingBase && entity != npc) { | ||
| EntityLivingBase livingTarget = (EntityLivingBase) entity; | ||
| for (Entity currentEntity : entities) { | ||
| if (currentEntity instanceof EntityLivingBase && currentEntity != entity) { |
Contributor
There was a problem hiding this comment.
if (currentEntity != entity && currentEntity instanceof EntityLivingBase)
PeTcHeNkA
reviewed
Feb 5, 2026
Comment on lines
+395
to
+396
| if (!(currentEntity instanceof EntityLivingBase)) continue; | ||
| if (currentEntity == entity) continue; |
Contributor
There was a problem hiding this comment.
if (currentEntity == entity || !(currentEntity instanceof EntityLivingBase)) continue;
PeTcHeNkA
reviewed
Feb 5, 2026
Comment on lines
+238
to
+239
| if (currentEntity == entity) continue; | ||
| if (currentEntity.isDead) continue; |
Contributor
There was a problem hiding this comment.
if (currentEntity.isDead || currentEntity == entity) continue;
PeTcHeNkA
reviewed
Feb 5, 2026
Comment on lines
+98
to
+99
| if (currentEntity == entity) continue; | ||
| if (currentEntity.isDead) continue; |
Contributor
There was a problem hiding this comment.
if (currentEntity.isDead || currentEntity == entity) continue;
PeTcHeNkA
reviewed
Feb 5, 2026
| public boolean check(EntityNPCInterface npc, EntityLivingBase target) { | ||
| return npc.getHealth() / npc.getMaxHealth() > threshold; | ||
| public boolean check(IAbilityHolder entity, EntityLivingBase target) { | ||
| return ((EntityLivingBase) entity).getHealth() / ((EntityLivingBase) entity).getMaxHealth() > threshold; |
Contributor
There was a problem hiding this comment.
fuck, why double cast ?
final EntityLivingBase living = (EntityLivingBase) entity;
return (living.getHealth() / living.getMaxHealth()) > threshold;
PeTcHeNkA
reviewed
Feb 5, 2026
| public boolean check(EntityNPCInterface npc, EntityLivingBase target) { | ||
| return npc.getHealth() / npc.getMaxHealth() < threshold; | ||
| public boolean check(IAbilityHolder entity, EntityLivingBase target) { | ||
| return ((EntityLivingBase) entity).getHealth() / ((EntityLivingBase) entity).getMaxHealth() < threshold; |
Contributor
There was a problem hiding this comment.
wtfffffffffffff why method logic is doubled ????
also:
final EntityLivingBase living = (EntityLivingBase) entity;
return (living.getHealth() / living.getMaxHealth()) < threshold;
PeTcHeNkA
reviewed
Feb 5, 2026
Comment on lines
234
to
+236
| // Check NPC's recent hit count from DataAbilities | ||
| if (npc.abilities != null) { | ||
| return npc.abilities.getRecentHitCount(withinTicks) >= requiredHits; | ||
| if (entity.getAbilityData() != null) { | ||
| return entity.getAbilityData().getRecentHitCount(withinTicks) >= requiredHits; |
Contributor
There was a problem hiding this comment.
wtf and getter is doubled!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be quite a few incompat